netdev - Re: [PATCH net-next] rtnetlink: validate attributes in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66acac36-a304-b743-8c6e-ef9cc87366d3@gmail.com>
Date:   Tue, 5 Jun 2018 09:42:54 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, dvyukov@...gle.com
Subject: Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()



On 06/05/2018 09:41 AM, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Tue,  5 Jun 2018 09:25:19 -0700
> 
>> It seems that rtnl_group_changelink() can call do_setlink
>> while a prior call to validate_linkmsg(dev = NULL, ...) could
>> not validate IFLA_ADDRESS / IFLA_BROADCAST
>>
>> Make sure do_setlink() calls validate_linkmsg() instead
>> of letting its callers having this responsibility.
> 
> But now rtnl_newlink() will validate_linkmsg() twice....
> 

Yes, is it a problem ? That is hardly fast path :)