netdev - Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180605141011.144bd604@xeon-e3>
Date:   Tue, 5 Jun 2018 14:10:11 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Keara Leibovitz <kleib@...atatu.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org, kernel@...atatu.com
Subject: Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum
 action

On Tue,  5 Jun 2018 16:44:19 -0400
Keara Leibovitz <kleib@...atatu.com> wrote:

> diff --git a/tc/m_csum.c b/tc/m_csum.c
> index 8391071d73f2..0bdbcf361a28 100644
> --- a/tc/m_csum.c
> +++ b/tc/m_csum.c
> @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg)
>  	char *uflag_5 = "";
>  	char *uflag_6 = "";
>  	char *uflag_7 = "";
> +	char buf[64];

Looks good.
In iproute2 the common macro for declaring these kind of buffers is:
	SPRINT_BUF(buf);

Doesn't matter that much, but nice to have consistency.