[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 6 Jun 2018 13:17:44 -0700
From: Jakub Kicinski <jakub.kicinski@...ronome.com>
To: Toke Høiland-Jørgensen <toke@...e.dk>
Cc: Linux Netdev List <netdev@...r.kernel.org>,
Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH bpf-next v5 1/2] trace_helpers.c: Add helpers to poll
multiple perf FDs for events
On Wed, Jun 6, 2018 at 10:51 AM, Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <jakub.kicinski@...ronome.com> writes:
>
>> On Wed, 06 Jun 2018 14:43:39 +0200, Toke Høiland-Jørgensen wrote:
>>> Add two new helper functions to trace_helpers that supports polling
>>> multiple perf file descriptors for events. These are used to the XDP
>>> perf_event_output example, which needs to work with one perf fd per CPU.
>>>
>>> Signed-off-by: Toke Høiland-Jørgensen <toke@...e.dk>
>>
>> malloc() + memset(0) could have been replaced with calloc, but
>> otherwise looks good.
>
> Ah right. I'll fix that and your nit for the other patch and resubmit
> with your reviewed-by tag. Thanks for reviewing!
Thank you :)
Powered by blists - more mailing lists