netdev - Re: [PATCH] ip_tunnel: Fix name string concatenate in __ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180607.163217.1969842151919332410.davem@davemloft.net>
Date:   Thu, 07 Jun 2018 16:32:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     sultanxda@...il.com
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] ip_tunnel: Fix name string concatenate in
 __ip_tunnel_create()

From: Sultan Alsawaf <sultanxda@...il.com>
Date: Wed,  6 Jun 2018 15:56:54 -0700

> By passing a limit of 2 bytes to strncat, strncat is limited to writing
> fewer bytes than what it's supposed to append to the name here.
> 
> Since the bounds are checked on the line above this, just remove the string
> bounds checks entirely since they're unneeded.
> 
> Signed-off-by: Sultan Alsawaf <sultanxda@...il.com>

Applied.