netdev - Re: [PATCH] net-fq: Add WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jun 2018 09:17:18 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     greearb@...delatech.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net-fq: Add WARN_ON check for null flow.



On 06/07/2018 09:06 AM, greearb@...delatech.com wrote:
> From: Ben Greear <greearb@...delatech.com>
> 
> While testing an ath10k firmware that often crashed under load,
> I was seeing kernel crashes as well.  One of them appeared to
> be a dereference of a NULL flow object in fq_tin_dequeue.
> 
> I have since fixed the firmware flaw, but I think it would be
> worth adding the WARN_ON in case the problem appears again.
> 
>  common_interrupt+0xf/0xf
>  </IRQ>
> 

Please find the exact commit that brought this bug,
and add a corresponding Fixes: tag

> Signed-off-by: Ben Greear <greearb@...delatech.com>
> ---
>  include/net/fq_impl.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/net/fq_impl.h b/include/net/fq_impl.h
> index be7c0fa..e40354d 100644
> --- a/include/net/fq_impl.h
> +++ b/include/net/fq_impl.h
> @@ -80,6 +80,9 @@ static struct sk_buff *fq_tin_dequeue(struct fq *fq,
>  
>  	flow = list_first_entry(head, struct fq_flow, flowchain);
>  
> +	if (WARN_ON_ONCE(!flow))
> +		return NULL;
> +
>  	if (flow->deficit <= 0) {
>  		flow->deficit += fq->quantum;
>  		list_move_tail(&flow->flowchain,
>