netdev - Re: Fw: [Bug 199963] New: UDP rx_queue incorrect calculation in /proc/net/udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e99d1e6e54b59831eef6113aff9a740769cf96a7.camel@redhat.com>
Date:   Thu, 07 Jun 2018 18:28:47 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: Fw: [Bug 199963] New: UDP rx_queue incorrect calculation in
 /proc/net/udp

On Thu, 2018-06-07 at 07:39 -0700, Stephen Hemminger wrote:
> 
> Begin forwarded message:
> 
> Date: Thu, 07 Jun 2018 13:21:23 +0000
> From: bugzilla-daemon@...zilla.kernel.org
> To: stephen@...workplumber.org
> Subject: [Bug 199963] New: UDP rx_queue incorrect calculation in /proc/net/udp
> 
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=199963
> 
>             Bug ID: 199963
>            Summary: UDP rx_queue incorrect calculation in /proc/net/udp
>            Product: Networking
>            Version: 2.5
>     Kernel Version: Kernels >= 4.15
>           Hardware: All
>                 OS: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: IPV4
>           Assignee: stephen@...workplumber.org
>           Reporter: trevor.francis@...abs.com
>         Regression: No
> 
> since upgrading to any kernel >= 4.15 the rx_queue in /proc/net/udp is now
> reporting a queue, regardless of system load and regardless of what
> applications are running on it. The tx_queue is always 0, but rx_queue has
> seemingly random spikes of udp queueing. This is observed across hundreds of
> servers with either varying or no workload.
> 
> netstat -nl|grep ^udp
> udp 4352 0 0.0.0.0:68 0.0.0.0:*
> 
> sl local_address rem_address st tx_queue rx_queue tr tm->when retrnsmt uid
> timeout inode ref pointer drops
> 14645: 3500007F:0035 00000000:0000 07 00000000:0000C900 00:00000000 00000000
> 101 0 3367 2 ffff8da177fdcc00 0

after:

commit 0d4a6608f68c7532dcbfec2ea1150c9761767d03
Author: Paolo Abeni <pabeni@...hat.com>
Date:   Tue Sep 19 12:11:43 2017 +0200

    udp: do rmem bulk free even if the rx sk queue is empty

rmem can be a non-0, small, value even if the rx queue is empty,
because it reports the (forward) allocated memory for this socket, not
the queue length in bytes. 

I'll cook a patch to fix the above.

Cheers,

Paolo