netdev - Re: [PATCH ipsec] vti6: fix PMTU caching and reporting on xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180608061905.bqbchoafzsbnldw2@gauss3.secunet.de>
Date:   Fri, 8 Jun 2018 08:19:05 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Eyal Birger <eyal.birger@...il.com>
CC:     <netdev@...r.kernel.org>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>
Subject: Re: [PATCH ipsec] vti6: fix PMTU caching and reporting on xmit

On Thu, Jun 07, 2018 at 10:11:02AM +0300, Eyal Birger wrote:
> When setting the skb->dst before doing the MTU check, the route PMTU
> caching and reporting is done on the new dst which is about to be
> released.
> 
> Instead, PMTU handling should be done using the original dst.
> 
> This is aligned with IPv4 VTI.
> 
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> Fixes: ccd740cbc6 ("vti6: Add pmtu handling to vti6_xmit.")

Patch applied, thanks for catching this Eyal!