netdev - RE: [iproute2 1/1] tipc: TIPC_NLA_LINK_NAME value pass on nesting entry TIPC_NLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Jun 2018 07:26:18 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Hoang Huu Le <hoang.h.le@...tech.com.au>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "maloy@...jonn.com" <maloy@...jonn.com>,
        "ying.xue@...driver.com" <ying.xue@...driver.com>
Subject: RE: [iproute2 1/1] tipc: TIPC_NLA_LINK_NAME value pass on nesting
 entry TIPC_NLA_LINK

Acked-by: Jon Maloy <jon.maloy@...csson.com>



> -----Original Message-----
> From: Hoang Le <hoang.h.le@...tech.com.au>
> Sent: Friday, 08 June, 2018 04:19
> To: netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net; Jon
> Maloy <jon.maloy@...csson.com>; maloy@...jonn.com;
> ying.xue@...driver.com
> Subject: [iproute2 1/1] tipc: TIPC_NLA_LINK_NAME value pass on nesting
> entry TIPC_NLA_LINK
> 
> In the commit 94f6a80 on next-net, TIPC_NLA_LINK_NAME attribute should
> be retrieved and validated via TIPC_NLA_LINK nesting entry in
> tipc_nl_node_get_link().
> According to that commit, TIPC_NLA_LINK_NAME value passing via tipc link
> get command must follow above hierachy.
> 
> Acked-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Hoang Le <hoang.h.le@...tech.com.au>
> ---
>  tipc/link.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tipc/link.c b/tipc/link.c
> index 02f14aadefa6..a2d7c0016bc1 100644
> --- a/tipc/link.c
> +++ b/tipc/link.c
> @@ -97,6 +97,7 @@ static int cmd_link_get_prop(struct nlmsghdr *nlh,
> const struct cmd *cmd,  {
>  	int prop;
>  	char buf[MNL_SOCKET_BUFFER_SIZE];
> +	struct nlattr *attrs;
>  	struct opt *opt;
>  	struct opt opts[] = {
>  		{ "link",		OPT_KEYVAL,	NULL },
> @@ -131,7 +132,9 @@ static int cmd_link_get_prop(struct nlmsghdr *nlh,
> const struct cmd *cmd,
>  		fprintf(stderr, "error, missing link\n");
>  		return -EINVAL;
>  	}
> +	attrs = mnl_attr_nest_start(nlh, TIPC_NLA_LINK);
>  	mnl_attr_put_strz(nlh, TIPC_NLA_LINK_NAME, opt->val);
> +	mnl_attr_nest_end(nlh, attrs);
> 
>  	return msg_doit(nlh, link_get_cb, &prop);  }
> --
> 2.1.4