netdev - Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode

Open Source and information security mailing list archives

Message-ID: <CA+Kvs9m_XnE-4F+R9jKD4sD9=7eQP7rBidA_7Hi0XVLs7-KhUA@mail.gmail.com>
Date:   Fri, 8 Jun 2018 18:08:02 +0300
From:   Ramon Fried <ramon.fried@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Eyal Ilsar <eilsar@...eaurora.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        wcn36xx@...ts.infradead.org
Subject: Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode

On Thu, Jun 7, 2018 at 3:45 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
>     drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program
>     drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program
>     drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
>     drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text
>
> and after:
>
>     drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks Geert !
Acked-by: Ramon Fried <ramon.fried@...il.com>

> ---
>  drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c
> index 1279064a3b716c2e..51a038022c8b8040 100644
> --- a/drivers/net/wireless/ath/wcn36xx/testmode.c
> +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c
> @@ -1,4 +1,4 @@
> -/*
> +/*
>   * Copyright (c) 2018, The Linux Foundation. All rights reserved.
>   *
>   * Permission to use, copy, modify, and/or distribute this software for any
> --
> 2.7.4
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives