netdev - Re: [PATCH] net: phy: dp83822: use BMCR_ANENABLE instead of BMSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180610.123913.2160801919208192012.davem@davemloft.net>
Date:   Sun, 10 Jun 2018 12:39:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alvaro.gamez@...ent.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: dp83822: use BMCR_ANENABLE instead of
 BMSR_ANEGCAPABLE for DP83620

From: Alvaro Gamez Machado <alvaro.gamez@...ent.com>
Date: Fri,  8 Jun 2018 12:23:39 +0200

> DP83620 register set is compatible with the DP83848, but it also supports
> 100base-FX. When the hardware is configured such as that fiber mode is
> enabled, autonegotiation is not possible.
> 
> The chip, however, doesn't expose this information via BMSR_ANEGCAPABLE.
> Instead, this bit is always set high, even if the particular hardware
> configuration makes it so that auto negotiation is not possible [1]. Under
> these circumstances, the phy subsystem keeps trying for autonegotiation to
> happen, without success.
> 
> Hereby, we inspect BMCR_ANENABLE bit after genphy_config_init, which on
> reset is set to 0 when auto negotiation is disabled, and so we use this
> value instead of BMSR_ANEGCAPABLE.
> 
> [1] https://e2e.ti.com/support/interface/ethernet/f/903/p/697165/2571170
> 
> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez@...ent.com>

Applied and queued up for -stable, thanks.