netdev - Re: [net] fq_codel: fix NULL pointer deref in fq_codel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXyR2Q-O1EfbGaCFfsQUAw=g_AUq8E6evzM9jVXQuWPXg@mail.gmail.com>
Date:   Mon, 11 Jun 2018 13:22:40 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jogreene@...hat.com" <jogreene@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [net] fq_codel: fix NULL pointer deref in fq_codel_reset

On Mon, Jun 11, 2018 at 12:57 PM, Keller, Jacob E
<jacob.e.keller@...el.com> wrote:
>
> I'm open to alternative suggestinos for fixing this, I think Eric suggested that maybe we should just remove the ->reset() call from qdisc_destroy..?

You can't remove ->reset() for non-failure call path.

For failure path, yeah, but it is much simpler to just make
q->flows_cnt be 0 for this specific case.