netdev - Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c486bcbac7302616f1bd651b4d2baad@codeaurora.org>
Date:   Tue, 12 Jun 2018 12:51:37 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Lorenzo Colitti <lorenzo@...gle.com>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK

> Have you considered putting this earlier up in the output, where the
> mark is printed as well?
> 
>> +       if (tb[XFRMA_OUTPUT_MARK]) {
>> +               __u32 output_mark = 
>> rta_getattr_u32(tb[XFRMA_OUTPUT_MARK]);
>> +
>> +               fprintf(fp, "\toutput-mark 0x%x %s", output_mark, 
>> _SL_);
>> +       }
>>  }
> 
> If you wanted to implement the suggestion above, I think you could do
> that by moving this code into xfrm_xfrma_print.
> 

Hi Lorenzo

I have updated it now in v2.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project