netdev - Re: [PATCH RFC] tcp: Do not reload skb pointer after skb_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f70f39b8-d3ab-132a-2447-3dd1c813e7b9@gmail.com>
Date:   Mon, 11 Jun 2018 19:59:37 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     edumazet@...gle.com
Subject: Re: [PATCH RFC] tcp: Do not reload skb pointer after
 skb_gro_receive().

On 06/11/2018 06:00 PM, David Miller wrote:
> 
> This is not necessary.  skb_gro_receive() will never change what
> 'head' points to.
> 
> In it's original implementation (see commit 71d93b39e52e ("net: Add
> skb_gro_receive")), it did:
> 
> ====================
> +	*head = nskb;
> +	nskb->next = p->next;
> +	p->next = NULL;
> ====================
> 
> This sequence was removed in commit 58025e46ea2d ("net: gro: remove
> obsolete code from skb_gro_receive()")
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

SGTM, thanks David !

Signed-off-by: Eric Dumazet <edumazet@...gle.com>