netdev - Re: [PATCH] net: add error handling for kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jun 2018 21:31:47 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Zhouyang Jia <jiazhouyang09@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Wei Wang <weiwan@...gle.com>, Martin KaFai Lau <kafai@...com>,
        Kees Cook <keescook@...omium.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Westphal <fw@...len.de>, Joe Perches <joe@...ches.com>,
        linux-decnet-user@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: add error handling for kmem_cache_create



On 06/11/2018 09:29 PM, Zhouyang Jia wrote:
> When kmem_cache_create fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling kmem_cache_create.
> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@...il.com>
> ---
>  net/decnet/dn_route.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index e747650..2b743c7 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1861,6 +1861,9 @@ void __init dn_route_init(void)
>  	dn_dst_ops.kmem_cachep =
>  		kmem_cache_create("dn_dst_cache", sizeof(struct dn_route), 0,
>  				  SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
> +	if (!dn_dst_ops.kmem_cachep)
> +		panic("Failed to create dn_dst_cache cache\n");
> +

Not needed, since SLAB_PANIC would have paniced the box earlier.

>  	dst_entries_init(&dn_dst_ops);
>  	timer_setup(&dn_route_timer, dn_dst_check_expire, 0);
>  	dn_route_timer.expires = jiffies + decnet_dst_gc_interval * HZ;
>