netdev - Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 5/7] net: Add generic ndo_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jun 2018 17:52:57 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     kbuild test robot <lkp@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     Alexander Duyck <alexander.h.duyck@...el.com>,
        Netdev <netdev@...r.kernel.org>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        kbuild-all@...org
Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATCH 5/7] net: Add
 generic ndo_select_queue functions

Jeff,

Looks like I have some bugs on non-x86 architecture. I need to address
these in a v2 of this set so please hold off on applying until I can
get that submitted either tonight or tomorrow morning.

Thanks.

- Alex

On Mon, Jun 11, 2018 at 4:10 PM, kbuild test robot <lkp@...el.com> wrote:
> Hi Alexander,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
> [also build test ERROR on next-20180608]
> [cannot apply to v4.17]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Alexander-Duyck/Add-support-for-L2-Fwd-Offload-w-o-ndo_select_queue/20180612-015220
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=arm
>
> All errors (new ones prefixed by >>):
>
>>> drivers/net//ethernet/ti/netcp_core.c:1968:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>      .ndo_select_queue = dev_pick_tx_zero,
>                          ^~~~~~~~~~~~~~~~
>    drivers/net//ethernet/ti/netcp_core.c:1968:22: note: (near initialization for 'netcp_netdev_ops.ndo_select_queue')
>    cc1: some warnings being treated as errors
>
> vim +1968 drivers/net//ethernet/ti/netcp_core.c
>
>   1955
>   1956  static const struct net_device_ops netcp_netdev_ops = {
>   1957          .ndo_open               = netcp_ndo_open,
>   1958          .ndo_stop               = netcp_ndo_stop,
>   1959          .ndo_start_xmit         = netcp_ndo_start_xmit,
>   1960          .ndo_set_rx_mode        = netcp_set_rx_mode,
>   1961          .ndo_do_ioctl           = netcp_ndo_ioctl,
>   1962          .ndo_get_stats64        = netcp_get_stats,
>   1963          .ndo_set_mac_address    = eth_mac_addr,
>   1964          .ndo_validate_addr      = eth_validate_addr,
>   1965          .ndo_vlan_rx_add_vid    = netcp_rx_add_vid,
>   1966          .ndo_vlan_rx_kill_vid   = netcp_rx_kill_vid,
>   1967          .ndo_tx_timeout         = netcp_ndo_tx_timeout,
>> 1968          .ndo_select_queue       = dev_pick_tx_zero,
>   1969          .ndo_setup_tc           = netcp_setup_tc,
>   1970  };
>   1971
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation