netdev - Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jun 2018 18:02:48 +0530
From:   Govind Singh <govinds@...eaurora.org>
To:     niklas.cassel@...aro.org, kvalo@...eaurora.org, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: FW: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST

On 2018-06-12 17:45, Govind Singh wrote:
> -----Original Message-----
> From: ath10k <ath10k-bounces@...ts.infradead.org> On Behalf Of Niklas 
> Cassel
> Sent: Tuesday, June 12, 2018 5:09 PM
> To: Kalle Valo <kvalo@...eaurora.org>; David S. Miller 
> <davem@...emloft.net>
> Cc: Niklas Cassel <niklas.cassel@...aro.org>; netdev@...r.kernel.org;
> linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> ath10k@...ts.infradead.org
> Subject: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST
> 
> ATH10K_SNOC builds just fine with COMPILE_TEST, so make that possible.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...aro.org>
> ---
>  drivers/net/wireless/ath/ath10k/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/Kconfig
> b/drivers/net/wireless/ath/ath10k/Kconfig
> index 54ff5930126c..6572a43590a8 100644
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -42,7 +42,8 @@ config ATH10K_USB
> 
>  config ATH10K_SNOC
>  	tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
> -	depends on ATH10K && ARCH_QCOM
> +	depends on ATH10K
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	---help---
>  	  This module adds support for integrated WCN3990 chip connected
>  	  to system NOC(SNOC). Currently work in progress and will not

Thanks Niklas for enabling COMPILE_TEST. With QMI set of 
changes(https://patchwork.kernel.org/patch/10448183/), we need to enable 
COMPILE_TEST for
QCOM_SCM/QMI_HELPERS which seems broken today. Are you planning to fix 
the same.

  config QCOM_SCM
  	bool
-	depends on ARM || ARM64
+	depends on ARM || ARM64 || COMPILE_TEST
  	select RESET_CONTROLLER


  config QCOM_SCM_64
  	def_bool y
-	depends on QCOM_SCM && ARM64
+	depends on QCOM_SCM && ARM64 || COMPILE_TEST

  config QCOM_QMI_HELPERS
  	tristate
-	depends on ARCH_QCOM && NET
+	depends on (ARCH_QCOM || COMPILE_TEST) && NET

-obj-$(CONFIG_ARCH_QCOM)		+= qcom/
+obj-y				+= qcom/

__qcom_scm_init/qcom_scm_call wrapper to support COMPILE_TEST.



BR,
Govind