netdev - Re: [PATCH] net: stmmac: fix build failure due to missing COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdaOuK2F0ENpwGf7HKVqXa13fe10rugYjLaQCTY7DbiaQ@mail.gmail.com>
Date:   Tue, 12 Jun 2018 19:35:04 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     David Miller <davem@...emloft.net>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Giuseppe CAVALLARO <peppe.cavallaro@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH] net: stmmac: fix build failure due to missing COMMON_CLK dependency

On Fri, Jun 8, 2018 at 5:59 PM, David Miller <davem@...emloft.net> wrote:
> From: Corentin Labbe <clabbe@...libre.com>
> Date: Wed,  6 Jun 2018 18:45:22 +0000
>
>> This patch fix the build failure on m68k;
>> drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.o: In function `ipq806x_gmac_probe':
>> dwmac-ipq806x.c:(.text+0xda): undefined reference to `clk_set_rate'
>> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.o: In function `rk_gmac_probe':
>> dwmac-rk.c:(.text+0x1e58): undefined reference to `clk_set_rate'
>> drivers/net/ethernet/stmicro/stmmac/dwmac-sti.o: In function `stid127_fix_retime_src':
>> dwmac-sti.c:(.text+0xd8): undefined reference to `clk_set_rate'
>> dwmac-sti.c:(.text+0x114): undefined reference to `clk_set_rate'
>> drivers/net/ethernet/stmicro/stmmac/dwmac-sti.o:dwmac-sti.c:(.text+0x12c): more undefined references to `clk_set_rate' follow
>> Lots of stmmac platform drivers need COMMON_CLK in their Kconfig depends.
>>
>> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
>
> Applied.

I think Geert has a better fix https://lkml.org/lkml/2018/6/11/122

-- 
With Best Regards,
Andy Shevchenko