netdev - Re: [PATCH net] net: qcom/emac: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bae4b8f-6235-8c28-61f9-88d574084d6a@codeaurora.org>
Date:   Wed, 13 Jun 2018 15:45:02 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Hemanth Puranik <hpuranik@...eaurora.org>
Subject: Re: [PATCH net] net: qcom/emac: Add missing of_node_put()

On 06/11/2018 08:03 AM, YueHaibing wrote:
> Add missing of_node_put() call for device node returned by
> of_parse_phandle().
> 
> Signed-off-by: YueHaibing<yuehaibing@...wei.com>

Acked-by: Timur Tabi <timur@...eaurora.org>

This seems legit.  The comment for of_find_device_by_node() that says 
the np needs to be released was added after the code was written, so 
it's possible that I didn't know at the time that this was a requirement.

However, I no longer have the ability to test EMAC on device tree 
platforms, so I can't verify this code.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.