netdev - Re: [PATCH net/jkirsher] bpf, xdp, i40e: fix i40e_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d56adbb7-12df-c197-1976-3eb161af8484@gmail.com>
Date:   Wed, 13 Jun 2018 09:26:12 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>, jeffrey.t.kirsher@...el.com
Cc:     intel-wired-lan@...ts.osuosl.org, keith.busch@...ux.intel.com,
        makita.toshiaki@....ntt.co.jp, bjorn.topel@...el.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net/jkirsher] bpf, xdp, i40e: fix i40e_build_skb skb
 reserve and truesize

On 06/13/2018 02:04 AM, Daniel Borkmann wrote:
> Using skb_reserve(skb, I40E_SKB_PAD + (xdp->data - xdp->data_hard_start))
> is clearly wrong since I40E_SKB_PAD already points to the offset where
> the original xdp->data was sitting since xdp->data_hard_start is defined
> as xdp->data - i40e_rx_offset(rx_ring) where latter offsets to I40E_SKB_PAD
> when build skb is used.
> 
> However, also before cc5b114dcf98 ("bpf, i40e: add meta data support")
> this seems broken since bpf_xdp_adjust_head() helper could have been used
> to alter headroom and enlarge / shrink the frame and with that the assumption
> that the xdp->data remains unchanged does not hold and would push a bogus
> packet to upper stack.
> 
> ixgbe got this right in 924708081629 ("ixgbe: add XDP support for pass and
> drop actions"). In any case, fix it by removing the I40E_SKB_PAD from both
> skb_reserve() and truesize calculation.
> 
> Fixes: cc5b114dcf98 ("bpf, i40e: add meta data support")
> Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
> Reported-by: Keith Busch <keith.busch@...ux.intel.com>
> Reported-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> Cc: Björn Töpel <bjorn.topel@...el.com>
> Cc: John Fastabend <john.fastabend@...il.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 

Thanks! I missed this during review.

Acked-by: John Fastabend <john.fastabend@...il.com>