netdev - Re: [PATCH net] KEYS: DNS: fix parsing multiple options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8195.1528992870@warthog.procyon.org.uk>
Date:   Thu, 14 Jun 2018 17:14:30 +0100
From:   David Howells <dhowells@...hat.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>, keyrings@...r.kernel.org,
        Wang Lei <wang840925@...il.com>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH net] KEYS: DNS: fix parsing multiple options

The fix seems to work, but the use of kstrtoul():

	ret = kstrtoul(eq, 10, &derrno);

is incorrect since the buffer can't been modified to block out the next
argument if there is one, so the following fails:

	perl -e 'print "#dnserror=1#", "\x00" x 1' |
	keyctl padd dns_resolver desc @s

(Note this is preexisting and nothing to do with your patch).

I'm not sure how best to handle this.

Anyway, Dave, can you take Eric's patch into the net tree with:

	Acked-by: David Howells <dhowells@...hat.com>

David