netdev - Re: [RFC PATCH 12/12] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180614194515.GE17808@amd>
Date:   Thu, 14 Jun 2018 21:45:15 +0200
From:   Pavel Machek <pavel@....cz>
To:     Anchal Agarwal <anchalag@...zon.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, boris.ostrovsky@...cle.com, konrad.wilk@...cle.com,
        roger.pau@...rix.com, netdev@...r.kernel.org, jgross@...e.com,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        kamatam@...zon.com, fllinden@...zon.com, vallish@...zon.com,
        guruanb@...zon.com, eduval@...zon.com, rjw@...ysocki.net,
        len.brown@...el.com, linux-pm@...r.kernel.org, cyberax@...zon.com
Subject: Re: [RFC PATCH 12/12] PM / hibernate: update the resume offset on
 SNAPSHOT_SET_SWAP_AREA

Hi!

> From: Aleksei Besogonov <cyberax@...zon.com>
> 
> The SNAPSHOT_SET_SWAP_AREA is supposed to be used to set the hibernation
> offset on a running kernel to enable hibernating to a swap file.
> However, it doesn't actually update the swsusp_resume_block variable. As
> a result, the hibernation fails at the last step (after all the data is
> written out) in the validation of the swap signature in
> mark_swapfiles().
> 
> Before this patch, the command line processing was the only place where
> swsusp_resume_block was set.

Are you saying that suspend-to-file was broken, even on
non-virtualized systems?

If so, we may this to go in first...
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)