netdev - Re: [PATCH bpf] xdp: Fix handling of devmap in generic XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <beece494-6942-3f96-bd55-e892fdd37a87@lab.ntt.co.jp>
Date:   Thu, 14 Jun 2018 09:33:26 +0900
From:   Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH bpf] xdp: Fix handling of devmap in generic XDP

On 2018/06/13 18:27, kbuild test robot wrote:
> Hi Toshiaki,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on bpf/master]
> 
> url:    https://github.com/0day-ci/linux/commits/Toshiaki-Makita/xdp-Fix-handling-of-devmap-in-generic-XDP/20180613-161204
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master
> config: i386-randconfig-a1-201823 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from net//bpf/test_run.c:7:0:
>>> include/linux/bpf.h:594:16: warning: 'struct sk_buff' declared inside parameter list
>             struct bpf_prog *xdp_prog)
>                    ^
>>> include/linux/bpf.h:594:16: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> vim +594 include/linux/bpf.h
> 
>    591	
>    592	static inline int dev_map_generic_redirect(struct bpf_dtab_netdev *dst,
>    593						   struct sk_buff *skb,
>  > 594						   struct bpf_prog *xdp_prog)
>    595	{
>    596		return 0;
>    597	}
>    598	

Ugh I did build test for the entire tree with CONFIG_BPF_SYSCALL, and
net/core and kernel/bpf without CONFIG_BPF_SYSCALL but not net/bpf.
I'll make sure to test the entire tree next. will send v2.

-- 
Toshiaki Makita