netdev - Re: [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32533954.9n15W0HXMB@bentobox>
Date:   Thu, 14 Jun 2018 12:40:47 +0200
From:   Sven Eckelmann <sven@...fation.org>
To:     Omer Efrat <omer.efrat@...demg.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCH v2 3/5] batman: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Donnerstag, 14. Juni 2018 13:12:17 CEST Omer Efrat wrote:
> Since 'filled' member in station_info changed to u64, BIT_ULL macro
> should be used with NL80211_STA_INFO_* attribute types instead of BIT.
> 
> The BIT macro uses unsigned long type which some architectures handle as 32bit
> and this results in compilation warnings such as:
> 
> net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type
>   sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
>   ^
> 
> Signed-off-by: Omer Efrat <omer.efrat@...demg.com>
> ---
>  net/batman-adv/bat_v_elp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It is called "batman-adv" and not "batman". And when (as in commit) did it 
change to 64 bit?  Shouldn't there be a "Fixed: " line to know which kernels 
are affected (especially for the stable kernel developers).

Kind regards,
	Sven

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)