netdev - Re: [PATCH net] net: stmmac: Run HWIF Quirks after getting HW caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Jun 2018 09:39:30 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     Jose.Abreu@...opsys.com
Cc:     netdev@...r.kernel.org, Joao.Pinto@...opsys.com,
        Vitor.Soares@...opsys.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, dinh.linux@...il.com
Subject: Re: [PATCH net] net: stmmac: Run HWIF Quirks after getting HW caps

From: Jose Abreu <Jose.Abreu@...opsys.com>
Date: Fri, 15 Jun 2018 16:17:27 +0100

> Currently we were running HWIF quirks before getting HW capabilities.
> This is not right because some HWIF callbacks depend on HW caps.
> 
> Lets save the quirks callback and use it in a later stage.
> 
> This fixes Altera socfpga.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>
> Fixes: 5f0456b43140 ("net: stmmac: Implement logic to automatically select HW Interface")
> Reported-by: Dinh Nguyen <dinh.linux@...il.com>

Applied, thanks for fixing this.