netdev - Re: [PATCH iproute2 v3] ipaddress: strengthen check on 'label' input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180615111911.75d1437b@xeon-e3>
Date:   Fri, 15 Jun 2018 11:19:11 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Patrick Talbert <ptalbert@...hat.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v3] ipaddress: strengthen check on 'label'
 input

On Thu, 14 Jun 2018 15:46:57 +0200
Patrick Talbert <ptalbert@...hat.com> wrote:

> As mentioned in the ip-address man page, an address label must
> be equal to the device name or prefixed by the device name
> followed by a colon. Currently the only check on this input is
> to see if the device name appears at the beginning of the label
> string.
> 
> This commit adds an additional check to ensure label == dev or
> continues with a colon.
> 
> Signed-off-by: Patrick Talbert <ptalbert@...hat.com>
> Suggested-by: Stephen Hemminger <stephen@...workplumber.org>

Sure applied