netdev - Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1529096226.27158.51.camel@infradead.org>
Date:   Fri, 15 Jun 2018 21:57:06 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Kevin Darbyshire-Bryant <kevin@...byshire-bryant.me.uk>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Elena Reshetova <elena.reshetova@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Krzysztof Mazur <krzysiek@...lesie.net>,
        "3chas3@...il.com" <3chas3@...il.com>,
        Mathias Kresin <dev@...sin.me>
Subject: Re: [PATCH 07/17] net: convert sock.sk_wmem_alloc from atomic_t to
 refcount_t



On Fri, 2018-06-15 at 20:49 +0000, Kevin Darbyshire-Bryant wrote:
> 
> > That does end up being quite hairy. I don't think it's worth doing.
> > 
> > This should probably suffice to fix it...
> > 
> > Kevin this is going to conflict with the ifx_atm_alloc_skb() hack in
> > the tree you're working on, but that needs to be killed with fire
> > anyway. It's utterly pointless as discussed.
> 
> I had already done so as part of the last pastebin debug info round :-)
> 
> As regards your patch… MAGIC!  Works an absolute treat.  Will get
> that submitted along with the ‘nuke ifx_atm_alloc_skb’ patch to
> OpenWrt tomorrow.  For now, maybe my brain will let me sleep :-)
> 
> Thank you soooooo much for your help & patience.
> 
> Tested-by: Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>

Thanks. In the morning please could I trouble you to test the other
variants that you can manage — PPPoA with llc-encap, as well as br2684
and PPPoE over that?
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)