netdev - Re: [PATCH net 1/4] ipv6: Only emit append events for appended routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9431f049-eecd-0c6c-ec57-84e25187b765@gmail.com>
Date:   Fri, 15 Jun 2018 08:21:13 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net 1/4] ipv6: Only emit append events for appended routes

On 6/15/18 7:23 AM, Ido Schimmel wrote:
> Current code will emit an append event in the FIB notification chain for
> any route added with NLM_F_APPEND set, even if the route was not
> appended to any existing route.
> 
> This is inconsistent with IPv4 where such an event is only emitted when
> the new route is appended after an existing one.
> 
> Align IPv6 behavior with IPv4, thereby allowing listeners to more easily
> handle these events.
> 
> Fixes: f34436a43092 ("net/ipv6: Simplify route replace and appending into multipath route")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  net/ipv6/ip6_fib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Acked-by: David Ahern <dsahern@...il.com>