netdev - Re: [PATCH COMMITTED] bluetooth: hci_nokia: Don't include linux/unaligned/le

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Jun 2018 09:42:03 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH COMMITTED] bluetooth: hci_nokia: Don't include
 linux/unaligned/le_struct.h directly.

Hi Dave,

> This breaks the build as this header is not meant to be used in this
> way.
> 
> ./include/linux/unaligned/access_ok.h:8:28: error: redefinition of ‘get_unaligned_le16’
> static __always_inline u16 get_unaligned_le16(const void *p)
>                            ^~~~~~~~~~~~~~~~~~
> In file included from drivers/bluetooth/hci_nokia.c:32:
> ./include/linux/unaligned/le_struct.h:7:19: note: previous definition of ‘get_unaligned_le16’ was here
> static inline u16 get_unaligned_le16(const void *p)
> 
> Use asm/unaligned.h instead.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
> drivers/bluetooth/hci_nokia.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Regards

Marcel