netdev - Re: [PATCH] net: hamradio: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <051e78ff15ac6a2e647b0c8c539ac80b3aec6328.camel@perches.com>
Date:   Sun, 17 Jun 2018 11:15:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     Stefan Agner <stefan@...er.ch>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hamradio: remove unused variable

On Sun, 2018-06-17 at 15:03 +0200, Stefan Agner wrote:
> The array bpq_eth_addr is only used to get the size of an
> address. Remove the array and use the size of the array
> bcast_addr which is actually copied.
> 
> Also constify and tidy up the bcast_addr declaration.
> 
> This fixes a warning seen with clang:
> drivers/net/hamradio/bpqether.c:94:13: warning: variable 'bpq_eth_addr' is not
>       needed and will not be emitted [-Wunneeded-internal-declaration]
> static char bpq_eth_addr[6];
>             ^
> 1 warning generated.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/net/hamradio/bpqether.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
> index f347fd9c5b28..8c9c9977241e 100644
> --- a/drivers/net/hamradio/bpqether.c
> +++ b/drivers/net/hamradio/bpqether.c
> @@ -89,9 +89,7 @@
>  static const char banner[] __initconst = KERN_INFO \
>  	"AX.25: bpqether driver version 004\n";
>  
> -static char bcast_addr[6]={0xFF,0xFF,0xFF,0xFF,0xFF,0xFF};
> -
> -static char bpq_eth_addr[6];
> +static const char bcast_addr[6] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
>  
>  static int bpq_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *);
>  static int bpq_device_event(struct notifier_block *, unsigned long, void *);
> @@ -501,8 +499,8 @@ static int bpq_new_device(struct net_device *edev)
>  	bpq->ethdev = edev;
>  	bpq->axdev = ndev;
>  
> -	memcpy(bpq->dest_addr, bcast_addr, sizeof(bpq_eth_addr));
> -	memcpy(bpq->acpt_addr, bcast_addr, sizeof(bpq_eth_addr));
> +	memcpy(bpq->dest_addr, bcast_addr, sizeof(bcast_addr));
> +	memcpy(bpq->acpt_addr, bcast_addr, sizeof(bcast_addr));

Probably better to remove bcast_addr altogether and use

	eth_broadcast_addr(bpq->dst_addr);
	eth_broadcast_addr(bpq->acpt_addr);


>  
>  	err = register_netdevice(ndev);
>  	if (err)