netdev - Re: [PATCH 1/4] net/ncsi: Silence debug messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6304ffad4a55a78e0136aaa975e371b634f22af3.camel@perches.com>
Date:   Mon, 18 Jun 2018 13:49:09 -0700
From:   Joe Perches <joe@...ches.com>
To:     Joel Stanley <joel@....id.au>,
        Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] net/ncsi: Silence debug messages

On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote:
> In normal operation we see this series of messages as the host drives
> the network device:
> 
>  ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down
>  ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0
[...]
> This makes all of these messages netdev_dbg. They are still useful to
> debug eg. misbehaving network device firmware, but we do not need them
> filling up the kernel logs in normal operation.

trivia:

> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
[]
> @@ -1735,7 +1735,7 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd)
>  	if (unlikely(nd->state != ncsi_dev_state_functional))
>  		return;
>  
> -	netdev_info(nd->dev, "NCSI interface %s\n",
> +	netdev_dbg(nd->dev, "NCSI interface %s\n",
>  		    nd->link_up ? "up" : "down");

It's nicer to realign the multiple line statements
to the open parenthesis

> diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
[]
> @@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp,
>  	ncm->data[2] = data;
>  	ncm->data[4] = ntohl(lsc->oem_status);
>  
> -	netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
> -		    nc->id, data & 0x1 ? "up" : "down");
> +	netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n",
> +		   nc->id, data & 0x1 ? "up" : "down");

as was done for the rest of these...