netdev - Re: [PATCH net] net/ipv6: respect rcu grace period before freeing fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <860a906b-cd26-7d56-0319-e961e8f15df4@gmail.com>
Date:   Mon, 18 Jun 2018 09:49:00 -0600
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net/ipv6: respect rcu grace period before freeing
 fib6_info

On 6/18/18 6:24 AM, Eric Dumazet wrote:
> syzbot reported use after free that is caused by fib6_info being
> freed without a proper RCU grace period.
> 

...

> Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Ahern <dsahern@...il.com>
> Reported-by: syzbot+9e6d75e3edef427ee888@...kaller.appspotmail.com
> ---
>  include/net/ip6_fib.h | 5 +++--
>  net/ipv6/ip6_fib.c    | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 

I wondered if that was needed when flipping to the new data struct.
Apparently so. Thanks for the patch,

Acked-by: David Ahern <dsahern@...il.com>
Tested-by: David Ahern <dsahern@...il.com>