netdev - Re: [PATCH net] ipvlan: call dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 14:10:18 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Stefano Brivio <sbrivio@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Miller <davem@...emloft.net>,
        Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH net] ipvlan: call dev_change_flags when reset ipvlan mode

On Mon, Jun 18, 2018 at 7:04 AM, Hangbin Liu <liuhangbin@...il.com> wrote:
> @@ -94,10 +95,13 @@ static int ipvlan_set_port_mode(struct ipvl_port *port, u16 nval)
>                         mdev->l3mdev_ops = NULL;
>                 }
>                 list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
> +                       flags = ipvlan->dev->flags;
>                         if (nval == IPVLAN_MODE_L3 || nval == IPVLAN_MODE_L3S)
> -                               ipvlan->dev->flags |= IFF_NOARP;
> +                               dev_change_flags(ipvlan->dev,
> +                                                flags | IFF_NOARP);
>                         else
> -                               ipvlan->dev->flags &= ~IFF_NOARP;
> +                               dev_change_flags(ipvlan->dev,
> +                                                flags & ~IFF_NOARP);

You need to check the return value of dev_change_flags().