netdev - Re: [PATCH net] enic: do not overwrite error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180620.081056.797432796607384637.davem@davemloft.net>
Date:   Wed, 20 Jun 2018 08:10:56 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     gvaradar@...co.com
Cc:     netdev@...r.kernel.org, ben.hutchings@...ethink.co.uk,
        benve@...co.com, gregkh@...uxfoundation.org,
        alexander.levin@...rosoft.com
Subject: Re: [PATCH net] enic: do not overwrite error code

From: Govindarajulu Varadarajan <gvaradar@...co.com>
Date: Mon, 18 Jun 2018 10:01:05 -0700

> In failure path, we overwrite err to what vnic_rq_disable() returns. In
> case it returns 0, enic_open() returns success in case of error.
> 
> Reported-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>
> Fixes: e8588e268509 ("enic: enable rq before updating rq descriptors")
> Signed-off-by: Govindarajulu Varadarajan <gvaradar@...co.com>

Applied and queued up for -stable.