netdev - Re: [PATCH 3/4] ipw2x00: track time using boottime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 14:40:53 +0400
From:   Stanislav Yakovlev <stas.yakovlev@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>, y2038@...ts.linaro.org,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] ipw2x00: track time using boottime

On 18/06/2018, Arnd Bergmann <arnd@...db.de> wrote:
> The ipw2x00 driver family uses get_seconds() to read the current time
> for various purposes. This function is deprecated because of the 32-bit
> time_t overflow, and it can cause unexpected behavior when the time
> changes due to settimeofday() calls or leap second updates.
>
> In many cases, we want to use monotonic time instead, however ipw2x00
> explicitly tracks the time spent in suspend, so this changes the
> driver over to use ktime_get_boottime_seconds(), which is slightly
> slower, but not used in a fastpath here.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c | 18 +++++++++---------
>  drivers/net/wireless/intel/ipw2x00/ipw2100.h | 12 ++++++------
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c |  4 ++--
>  drivers/net/wireless/intel/ipw2x00/ipw2200.h |  6 +++---
>  4 files changed, 20 insertions(+), 20 deletions(-)
>

Acked-by: Stanislav Yakovlev <stas.yakovlev@...il.com>

Looks fine, thanks!

Stanislav.