netdev - Re: [PATCH net] ipvlan: call dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180620.143147.2291173423483856091.davem@davemloft.net>
Date:   Wed, 20 Jun 2018 14:31:47 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        sbrivio@...hat.com, pabeni@...hat.com, maheshb@...gle.com
Subject: Re: [PATCH net] ipvlan: call dev_change_flags when reset ipvlan
 mode

From: Hangbin Liu <liuhangbin@...il.com>
Date: Wed, 20 Jun 2018 11:22:54 +0800

> The only case dev_change_flags() return an err is when we change IFF_UP flag.
> Since we only set/reset IFF_NOARP, do you think we still need to check the
> return value?

It is bad to try and take shortcuts on error handling using assumptions
like that.

If dev_change_flags() is adjusted to return error codes in more
situations, nobody is going to remember to undo your "optimziation"
here.

Please check for errors, thank you.