netdev - Re: [PATCH] tc: fix batch force option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180620093305.1f23b4ed@xeon-e3>
Date:   Wed, 20 Jun 2018 09:33:05 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, chrism@...lanox.com
Subject: Re: [PATCH] tc: fix batch force option

On Wed, 20 Jun 2018 10:24:21 +0300
Vlad Buslov <vladbu@...lanox.com> wrote:

> When sending accumulated compound command results an error, check 'force'
> option before exiting. Move return code check after putting batch bufs and
> freeing iovs to prevent memory leak. Break from loop, instead of returning
> error code to allow cleanup at the end of batch function. Don't reset ret
> code on each iteration.
> 
> Fixes: 485d0c6001c4 ("tc: Add batchsize feature for filter and actions")
> Reviewed-by: Roi Dayan <roid@...lanox.com>
> Reviewed-by: Chris Mi <chrism@...lanox.com>
> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Applied