netdev - Re: [PATCH net v2] cls_flower: fix use after free in flower S/W path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180622.072505.191579217918884711.davem@davemloft.net>
Date:   Fri, 22 Jun 2018 07:25:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, marcelo.leitner@...il.com, paulb@...lanox.com
Subject: Re: [PATCH net v2] cls_flower: fix use after free in flower S/W
 path

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu, 21 Jun 2018 20:02:16 +0200

> If flower filter is created without the skip_sw flag, fl_mask_put()
> can race with fl_classify() and we can destroy the mask rhashtable
> while a lookup operation is accessing it.
 ...
> Fix the above waiting for a RCU grace period before destroying the
> rhashtable: we need to use tcf_queue_work(), as rhashtable_destroy()
> must run in process context, as pointed out by Cong Wang.
> 
> v1 -> v2: use tcf_queue_work to run rhashtable_destroy().
> 
> Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thanks.