netdev - Re: [PATCH net] cls_flower: fix use after free in flower S/W path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d8b83d0c8268d41822d814633405e2ac6a1d104.camel@redhat.com>
Date:   Thu, 21 Jun 2018 09:21:47 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Paul Blakey <paulb@...lanox.com>
Subject: Re: [PATCH net] cls_flower: fix use after free in flower S/W path

Hi,

On Wed, 2018-06-20 at 11:06 -0700, Cong Wang wrote:
> On Wed, Jun 20, 2018 at 10:34 AM, Paolo Abeni <pabeni@...hat.com> wrote:
> > 
> > +static void fl_mask_free(struct fl_flow_mask *mask)
> > +{
> > +       rhashtable_destroy(&mask->ht);
> 
> I don't believe you can call rhashtable_destroy() in BH
> context, it acquires a mutex...

Thank you for the review. You are right. Tomorrow (I'm on holiday
today) I'll look towards leverging tcf_queue_work() to schedule
fl_mask_free()/rhashtable_destroy() at a proper time. 

Cheers,

Paolo