netdev - Re: [PATCH net V2 1/1] net/smc: coordinate wait queues for nonblocking connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpVXEQ7yo-zopuZiwsx+3xYWTMzY-xwxOU0qysBz_y-4pw@mail.gmail.com>
Date:   Thu, 21 Jun 2018 19:12:05 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Ursula Braun <ubraun@...ux.ibm.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-s390@...r.kernel.org, schwidefsky@...ibm.com,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        raspl@...ux.ibm.com, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH net V2 1/1] net/smc: coordinate wait queues for
 nonblocking connect

On Thu, Jun 21, 2018 at 7:23 AM, Ursula Braun <ubraun@...ux.ibm.com> wrote:
> @@ -605,6 +606,13 @@ static int smc_connect(struct socket *sock, struct sockaddr *addr,
>
>         smc_copy_sock_settings_to_clc(smc);
>         tcp_sk(smc->clcsock->sk)->syn_smc = 1;
> +       if (flags & O_NONBLOCK) {
> +               rcu_read_lock();
> +               smc->smcwq = rcu_dereference(sk->sk_wq);
> +               rcu_assign_pointer(sock->sk->sk_wq,
> +                                  rcu_dereference(smc->clcsock->sk->sk_wq));
> +               rcu_read_unlock();

Are you really deref'ing any RCU pointer here?