netdev - Re: [PATCH net-next v4 1/2] r8169: Don't disable ASPM in the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180622.140831.1245451103607060086.davem@davemloft.net>
Date:   Fri, 22 Jun 2018 14:08:31 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     kai.heng.feng@...onical.com
Cc:     ryankao@...ltek.com, hayeswang@...ltek.com, hau@...ltek.com,
        hkallweit1@...il.com, romieu@...zoreil.com, bhelgaas@...gle.com,
        acelan.kao@...onical.com, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/2] r8169: Don't disable ASPM in the driver

From: Kai-Heng Feng <kai.heng.feng@...onical.com>
Date: Thu, 21 Jun 2018 16:30:38 +0800

> Enable or disable ASPM should be done in PCI core instead of in the
> device driver.
> 
> Commit ba04c7c93bbc ("r8169: disable ASPM") uses
> pci_disable_link_state() to disable ASPM, but it's not the best way to
> do it. If the device really wants to disable ASPM, we can use a quirk in
> PCI core to prevent the PCI core from setting ASPM before probe.
> 
> Let's remove pci_disable_link_state() for now. Use PCI core quirks if
> any regression happens.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Applied.