netdev - Re: [Patch net] net_sched: remove a bogus warning in hfsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Jun 2018 10:59:16 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, pupilla@...ero.it
Subject: Re: [Patch net] net_sched: remove a bogus warning in hfsc

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 22 Jun 2018 14:33:16 -0700

> In update_vf():
> 
>   cftree_remove(cl);
>   update_cfmin(cl->cl_parent);
> 
> the cl_cfmin of cl->cl_parent is intentionally updated to 0
> when that parent only has one child. And if this parent is
> root qdisc, we could end up, in hfsc_schedule_watchdog(),
> that we can't decide the next schedule time for qdisc watchdog.
> But it seems safe that we can just skip it, as this watchdog is
> not always scheduled anyway.
> 
> Thanks to Marco for testing all the cases, nothing is broken.
> 
> Reported-by: Marco Berizzi <pupilla@...ero.it>
> Tested-by: Marco Berizzi <pupilla@...ero.it>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks Cong.