netdev - Re: [PATCH] net: usb: asix: allow optionally getting mac address from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180625152806.GA11603@lunn.ch>
Date:   Mon, 25 Jun 2018 17:28:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dean_Jenkins@...tor.com" <Dean_Jenkins@...tor.com>,
        "andreyknvl@...gle.com" <andreyknvl@...gle.com>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] net: usb: asix: allow optionally getting mac address
 from device tree

> Now that you mentioned eth_platform_get_mac_address() on my igb attempt I am
> wondering whether that would not also be the better approach for ASIX USB net
> use. Looks like at least lan78xx already does it that way as well.
> 
> What do you think?

Hi Marcel

eth_platform_get_mac_address() is preferred, since it will try DT,
ACPI, and anything else the platform supports.

      Andrew