netdev - Re: [PATCH net-next 7/7] net: sched: call reoffload op on block callback reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180625141014.61501799@cakuba.netronome.com>
Date:   Mon, 25 Jun 2018 14:10:14 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, xiyou.wangcong@...il.com, jhs@...atatu.com,
        gerlitz.or@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, John Hurley <john.hurley@...ronome.com>
Subject: Re: [PATCH net-next 7/7] net: sched: call reoffload op on block
 callback reg

On Mon, 25 Jun 2018 22:58:32 +0200, Jiri Pirko wrote:
> Mon, Jun 25, 2018 at 06:34:31AM CEST, jakub.kicinski@...ronome.com wrote:
> >From: John Hurley <john.hurley@...ronome.com>  
> 
> [...]	
> 	
> >+static int
> >+tcf_block_playback_offloads(struct tcf_block *block, tc_setup_cb_t *cb,
> >+			    void *cb_priv, bool add, bool offload_in_use,
> >+			    struct netlink_ext_ack *extack)
> >+{
> >+	struct tcf_chain *chain;
> >+	struct tcf_proto *tp;
> >+	int err;
> >+
> >+	list_for_each_entry(chain, &block->chain_list, list) {
> >+		for (tp = rtnl_dereference(chain->filter_chain); tp;
> >+		     tp = rtnl_dereference(tp->next)) {
> >+			if (tp->ops->reoffload) {
> >+				err = tp->ops->reoffload(tp, add, cb, cb_priv,
> >+							 extack);
> >+				if (err && add)
> >+					goto err_playback_remove;
> >+			} else if (add && offload_in_use) {
> >+				err = -EOPNOTSUPP;
> >+				NL_SET_ERR_MSG(extack, "Filter replay failed - a filters doesn't support re-offloading");  
> 
> This msg sounds weird. Please fix it.

Indeed..  How about: 

"Filter HW offload failed - classifier without re-offloading support"

> Otherwise this looks very good to me! Thanks!

Cool, thanks for the comments!  I will respin shortly.