netdev - Re: [PATCH] igb: allow optionally getting mac address from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180625.170547.658198698048994134.davem@davemloft.net>
Date:   Mon, 25 Jun 2018 17:05:47 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     marcel@...wiler.com
Cc:     netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        jeffrey.t.kirsher@...el.com, marcel.ziswiler@...adex.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] igb: allow optionally getting mac address from device
 tree

From: Marcel Ziswiler <marcel@...wiler.com>
Date: Mon, 25 Jun 2018 10:00:42 +0200

> @@ -3122,7 +3124,11 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		break;
>  	}
>  
> -	if (eth_platform_get_mac_address(&pdev->dev, hw->mac.addr)) {
> +	/* try to get the MAC address from device tree data */
> +	iap = of_get_mac_address(pdev->dev.of_node);
> +	if (iap)
> +		memcpy(hw->mac.addr, iap, ETH_ALEN);

This is exactly what eth_platform_get_mac_address() shoule be doing.