netdev - Re: [PATCH net-next] route: add support for directed broadcast forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180625090956.GA19457@splinter.mtl.com>
Date:   Mon, 25 Jun 2018 12:09:56 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next] route: add support for directed broadcast
 forwarding

Hi Xin,

On Mon, Jun 25, 2018 at 10:45:08AM +0800, Xin Long wrote:
> This patch implements the feature described in rfc1812#section-5.3.5.2
> and rfc2644. It allows the router to forward directed broadcast when
> sysctl mc_forwarding is enabled.

You mean bc_forwarding?

> 
> Note that this feature could be done by iptables -j TEE, but it would
> cause some problems:
>   - target TEE's gateway param has to be set with a specific address,
>     and it's not flexible especially when the route wants forward all
>     directed broadcasts.
>   - this duplicates the directed broadcasts so this may cause side
>     effects to applications.
> 
> Besides, to keep consistent with other os router like BSD, it's also
> necessary to implement it in the route rx path.

Regarding the test you posted later in the thread, did you consider
adding it as part of tools/testing/selftests/net/forwarding/ ? I believe
you can write the test using VRFs instead of name spaces.

Thanks