netdev - Re: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wih4lhrgrfd.fsf@dev-r-vrt-156.mtr.labs.mlnx>
Date:   Mon, 25 Jun 2018 12:13:10 +0300
From:   Petr Machata <petrm@...lanox.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, jiri@...lanox.com,
        ilias.apalodimas@...aro.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs

Florian Fainelli <f.fainelli@...il.com> writes:

>  	if (netif_is_bridge_master(vlan->obj.orig_dev))
> -		return -EOPNOTSUPP;
> +		info.port = dp->cpu_dp->index;

The condition above will trigger also when a VLAN is added on a member
port, and there's no other port with that VLAN. In that case the VLAN
comes without the BRIDGE_VLAN_INFO_BRENTRY flag. In mlxsw we have this
to get the bridge VLANs:

	if (netif_is_bridge_master(orig_dev)) {
		[...]
		if ((vlan->flags & BRIDGE_VLAN_INFO_BRENTRY) &&
		[...]

This doesn't appear to be done in DSA unless I'm missing something.

Thanks,
Petr