netdev - [PATCH net-next] netlink: Return extack message if attribute validation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180626193918.25692-1-dsahern@kernel.org>
Date:   Tue, 26 Jun 2018 12:39:18 -0700
From:   dsahern@...nel.org
To:     netdev@...r.kernel.org
Cc:     jakub.kicinski@...ronome.com, David Ahern <dsahern@...il.com>
Subject: [PATCH net-next] netlink: Return extack message if attribute validation fails

From: David Ahern <dsahern@...il.com>

Have one extack message for parsing and validating.

Signed-off-by: David Ahern <dsahern@...il.com>
---
 lib/nlattr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/nlattr.c b/lib/nlattr.c
index dfa55c873c13..e335bcafa9e4 100644
--- a/lib/nlattr.c
+++ b/lib/nlattr.c
@@ -253,8 +253,8 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head,
 			if (policy) {
 				err = validate_nla(nla, maxtype, policy);
 				if (err < 0) {
-					if (extack)
-						extack->bad_attr = nla;
+					NL_SET_ERR_MSG_ATTR(extack, nla,
+							    "Attribute failed policy validation");
 					goto errout;
 				}
 			}
-- 
2.11.0