netdev - Re: [RFC PATCH v2 net-next 01/12] net: core: trivial netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fbb875b-c737-1b23-d56f-816e667e1e7f@gmail.com>
Date:   Tue, 26 Jun 2018 17:06:34 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Edward Cree <ecree@...arflare.com>,
        linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Cc:     davem@...emloft.net
Subject: Re: [RFC PATCH v2 net-next 01/12] net: core: trivial
 netif_receive_skb_list() entry point



On 06/26/2018 11:17 AM, Edward Cree wrote:
> Just calls netif_receive_skb() in a loop.

...

> +void netif_receive_skb_list(struct sk_buff_head *list)


Please use a standard list_head and standard list operators.

(In all your patches)

1) We do not want to carry a spinlock_t + count per list...

2) We get nice debugging features with CONFIG_DEBUG_LIST=y

Note that we now have skb->list after 
commit d4546c2509b1e9cd082e3682dcec98472e37ee5a ("net: Convert GRO SKB handling to list_head.")

Thanks !