netdev - Re: [PATCH ipsec-next 1/1] xfrm: don't check offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180627154941.xtqir64664qrssv5@gauss3.secunet.de>
Date:   Wed, 27 Jun 2018 17:49:41 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Shannon Nelson <shannon.nelson@...cle.com>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec-next 1/1] xfrm: don't check offload_handle for
 nonzero

On Tue, Jun 26, 2018 at 02:19:10PM -0700, Shannon Nelson wrote:
> The offload_handle should be an opaque data cookie for the driver
> to use, much like the data cookie for a timer or alarm callback.
> Thus, the XFRM stack should not be checking for non-zero, because
> the driver might use that to store an array reference, which could
> be zero, or some other zero but meaningful value.
> 
> We can remove the checks for non-zero because there are plenty
> other attributes also being checked to see if there is an offload
> in place for the SA in question.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@...cle.com>

I don't have access to my hw offload testlab currently,
so I've queued this one until I'm back from my vacation.