netdev - Re: [Patch net-next v3 1/3] net: introduce helper dev_change_tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2d5e8ea-0096-1c2e-b7d4-76c1172900c3@gmail.com>
Date:   Wed, 27 Jun 2018 09:14:40 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     john.fastabend@...il.com
Subject: Re: [Patch net-next v3 1/3] net: introduce helper
 dev_change_tx_queue_len()



On 01/25/2018 06:26 PM, Cong Wang wrote:
> This patch promotes the local change_tx_queue_len() to a core
> helper function, dev_change_tx_queue_len(), so that rtnetlink
> and net-sysfs could share the code. This also prepares for the
> following patch.
> 
> Note, the -EFAULT in the original code doesn't make sense,
> we should propagate the errno from notifiers.
> 
> Cc: John Fastabend <john.fastabend@...il.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  include/linux/netdevice.h |  1 +
>  net/core/dev.c            | 28 ++++++++++++++++++++++++++++
>  net/core/net-sysfs.c      | 25 +------------------------
>  net/core/rtnetlink.c      | 18 +++++-------------
>  4 files changed, 35 insertions(+), 37 deletions(-)
> 

Hi Cong

What about using dev_change_tx_queue_len() helper from SIOCSIFTXQLEN path in
net/core/dev_ioctl.c ?

This would make sure we call dev_qdisc_change_tx_queue_len() in this case.

Thanks !